[#21157][DocDb]: Fix load_balancer_max_over_replicated_tablets description to reflect per-table status #24406
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…s description Summary: Currently, the flag '--load_balancer_max_over_replicated_tablets' does not accurately reflect the fact that the setting is meant to be applicable per table. This commit looks to update the description of the flag to explicitly state that this settings is on a per-table basis (note: customers may already have flag overrides so naively changing flag name outright is not ideal) Test Plan: ./yb_release works Reviewers: Reviewed By: Subscribers: Tags: Differential Revision:
michaelzheng67
force-pushed
the
docdb-21157
branch
from
cedbd19
to
eeb6b72
Compare
✅ Deploy Preview for infallible-bardeen-164bc9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for infallible-bardeen-164bc9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
ddhodge
reviewed
Oct 18, 2024
| @@ -522,7 +522,7 @@ Default: `2` | |||
|
|
|||
| ##### --load_balancer_max_over_replicated_tablets | |||
|
|
|||
| Specifies the maximum number of running tablet replicas that are allowed to be over the configured replication factor. | |||
| Specifies the maximum number of running tablet replicas that are allowed to be over the configured replication factor per table. | |||
There was a problem hiding this comment.
Suggested change
| Specifies the maximum number of running tablet replicas that are allowed to be over the configured replication factor per table. | |
| Specifies the maximum number of running tablet replicas per table that are allowed beyond the configured replication factor. For example, if RF=3 and this flag is set to 3, you can have maximum 6 tablet replicas per table. |
ddhodge
reviewed
Oct 18, 2024
| @@ -68,7 +68,7 @@ DEFINE_RUNTIME_int32(load_balancer_max_concurrent_tablet_remote_bootstraps_per_t | |||
|
|
|||
| DEFINE_RUNTIME_int32(load_balancer_max_over_replicated_tablets, 1, | |||
| "Maximum number of running tablet replicas that are allowed to be over the configured " | |||
There was a problem hiding this comment.
Suggested change
| "Maximum number of running tablet replicas that are allowed to be over the configured " | |
| "Maximum number of running tablet replicas per table allowed in addition to the configured " |
| @@ -68,7 +68,7 @@ DEFINE_RUNTIME_int32(load_balancer_max_concurrent_tablet_remote_bootstraps_per_t | |||
|
|
|||
| DEFINE_RUNTIME_int32(load_balancer_max_over_replicated_tablets, 1, | |||
| "Maximum number of running tablet replicas that are allowed to be over the configured " | |||
| "replication factor."); | |||
| "replication factor per table."); | |||
There was a problem hiding this comment.
Suggested change
| "replication factor per table."); | |
| "replication factor."); |
| @@ -215,7 +215,7 @@ struct Options { | |||
| // time. | |||
| bool kAllowLimitOverReplicatedTablets = true; | |||
|
|
|||
| // Max number of running tablet replicas that are over the configured limit. | |||
| // Max number of running tablet replicas that are over the configured limit per table. | |||
There was a problem hiding this comment.
Suggested change
| // Max number of running tablet replicas that are over the configured limit per table. | |
| // Max number of running tablet replicas per table allowed over the configured RF. |
|
@SrivastavaAnubhav Can you TAL |
|
I'm talking to Michael about this on community slack. The best fix would actually be to do the following: introduce a new flag called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the flag '--load_balancer_max_over_replicated_tablets' does not accurately reflect the fact that the setting is meant to be applicable per table.
This commit looks to update the description of the flag to explicitly state that this settings is on a per-table basis (note: customers may already have flag overrides so naively changing flag name outright is not ideal)
Test Plan:
./yb_release works
Reviewers:
Reviewed By:
Subscribers:
Tags:
Differential Revision: